Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Nov 7, 2025

Fixes broken tests in main, seems related to #6518 but I might be wrong

Since this is related to logs, I would appreciate if you can review this @denrase

@codecov
Copy link

codecov bot commented Nov 7, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
3960 4 3956 55
View the top 3 failed test(s) by shortest run time
SentryTests.SentryCrashInstallationReporterTests::testReportIsSentAndDeleted
Stack Traces | 0s run time
.../SentryTests/SentryCrash/SentryCrashInstallationReporterTests.swift:23 - XCTAssertEqual failed: ("Optional(0)") is not equal to ("Optional(1)")
SentryTests.SentryHubTests::testCaptureLog_ReplayAttributes_BothSessionAndScopeReplayId_SessionMode
Stack Traces | 0s run time
.../Tests/SentryTests/SentryHubTests.swift:740 - XCTAssertEqual failed: ("1") is not equal to ("0")
SentryTests.SentryHubTests::testCaptureLog_ReplayAttributes_BufferMode_AddsReplayIdAndBufferingFlag
Stack Traces | 0s run time
.../Tests/SentryTests/SentryHubTests.swift:712 - XCTAssertEqual failed: ("1") is not equal to ("0")
iOS_SwiftUI_UITests.FeedbackUITests::testWidgetDisplayInSwiftUIApp
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/FeedbackUITests.swift:14 - Failed to get matching snapshots: Timed out while evaluating UI query.
iOS_Swift_UITests.TopViewControllerTests::testNavigationViewController
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/TopViewControllerTests.swift:19 - Failed to tap "Transactions" Button: Targeted element Button, {{82.0, 792.0}, {77.0, 48.0}}, label: 'Transactions' is no longer valid after interruption handling. This can happen with UI that auto-dismisses when it loses first-responder status, which may occur as part of interruption handling. A retry-loop around the event may resolve the issue.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when CI is green.

@philipphofmann philipphofmann added the ready-to-merge Use this label to trigger all PR workflows label Nov 10, 2025
@philipphofmann
Copy link
Member

philipphofmann commented Nov 10, 2025

FYI, I reverted the PR that caused these test failures. IMO, we should include the fixes when undoing the revert #6727.

@denrase
Copy link
Collaborator

denrase commented Nov 10, 2025

@itaybre Thx, i will pick this up once #6727 is merged.

@philipphofmann
Copy link
Member

I'm going to close this PR as I think @denrase will include this fix in his revert of the revert 😄. Please reopen if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants