Skip to content

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Dec 19, 2025

Attributes set on logs, metrics, or scopes mustn't contain references to live objects.

We don't have tests for this at the moment. It's important to be able to catch regressions in this behavior because it's part of the contract of before_send_log and before_send_metric.

@sentrivana sentrivana marked this pull request as ready for review December 19, 2025 08:50
@sentrivana sentrivana requested a review from a team as a code owner December 19, 2025 08:50
@sentrivana sentrivana merged commit d7aebef into master Dec 19, 2025
153 checks passed
@sentrivana sentrivana deleted the ivana/test-preserialization branch December 19, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants