Skip to content

ref: Properly override parent func #5283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sentrivana merged 1 commit into from
Jan 8, 2026
Merged

ref: Properly override parent func #5283

sentrivana merged 1 commit into from
Jan 8, 2026

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jan 8, 2026

The arg is called item in the parent batcher class. Doesn't really change anything functionality wise, but let's be properly generic.

@sentrivana sentrivana marked this pull request as ready for review January 8, 2026 08:24
@sentrivana sentrivana requested a review from a team as a code owner January 8, 2026 08:24
@sentrivana sentrivana changed the title ref: Properly overload parent func ref: Properly override parent func Jan 8, 2026
@sentrivana sentrivana merged commit dc8a8e5 into master Jan 8, 2026
153 checks passed
@sentrivana sentrivana deleted the ivana/batcher-fix branch January 8, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sentrivana @alexander-alderman-webb