Skip to content

fix(threading): Handle channels shadowing #5299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 2 commits into from
Jan 13, 2026
Merged

fix(threading): Handle channels shadowing #5299

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47aafc9
fix: Handle channels shadowing
sentrivana Jan 12, 2026
d34f796
make more future proof
sentrivana Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sentry_sdk/integrations/threading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,14 @@ def setup_once() -> None:

try:
from django import VERSION as django_version # noqa: N811
except ImportError:
django_version = None

try:
import channels # type: ignore[import-untyped]

channels_version = channels.__version__
except ImportError:
django_version = None
except (ImportError, AttributeError):
Copy link

@javiertejero javiertejero Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this implies that if there is an AttributeError because of channels line, django_version will be set to None and that is not ideal... perhaps we should split this try/except in 2 parts, 1 for django and another for channels?

Copy link

@javiertejero javiertejero Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this implies that if there is an AttributeError because of channels line, django_version will be set to None and that is not ideal... perhaps we should split this try/except in 2 parts, 1 for django and another for channels?

Copy link
Contributor Author

@sentrivana sentrivana Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ok, django_version and channels_version both are only used for warning about a very specific Django/channels/sentry-sdk incompatibility that only appears in specific versions.

But you raise a good point in that it's not clear what the variable is used for. It might happen that someone extends the logic at some point using django_version for some other purpose, not realizing it's not always populated correctly. So it's worth making this nicer.

Copy link
Contributor Author

@sentrivana sentrivana Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d34f796

channels_version = None

is_async_emulated_with_threads = (
Expand Down
Loading