Deslop simplifier swap #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new code-simplifier skill with comprehensive simplification guidelines - Remove old deslop skill directory - Update README.md to reference code-simplifier instead of deslop - Update .claude/settings.json with code-simplifier permission - Update claude-settings-audit skill to include code-simplifier in recommendations The code-simplifier skill is based on Anthropic's approach and provides more comprehensive code simplification beyond just removing slop, including simplifying complex logic, removing unnecessary abstractions, and improving code readability while maintaining functionality. Co-authored-by: david <[email protected]>
|
Cursor Agent can help with this pull request. Just |
- Create agents/ directory for subagents - Add code-simplifier.md subagent using Anthropic's official version - Remove code-simplifier from skills directory - Update README.md to document subagents separately from skills - Update .claude/settings.json to remove code-simplifier skill permission (subagents don't require permissions) - Update claude-settings-audit to not recommend code-simplifier skill - Update repository structure documentation The code-simplifier is now a proper subagent following Anthropic's official implementation from claude-plugins-official repo. Co-authored-by: david <[email protected]>
- Add source attribution comment to code-simplifier.md pointing to Anthropic's official repo - Create agents/README.md to document subagents and their sources - Ensures proper credit and traceability for externally sourced subagents Co-authored-by: david <[email protected]>
- Changed attribution from license reference to prior art acknowledgment - Verified that anthropics/claude-plugins-official has no license file - Updated both code-simplifier.md and agents/README.md accordingly - Clarifies we're noting this as prior art from Anthropic rather than claiming any specific license Co-authored-by: david <[email protected]>
- Remove license commentary from code-simplifier.md - Remove license mention from agents/README.md - Keep clean attribution showing it's based on Anthropic's subagent Co-authored-by: david <[email protected]>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+18
to
+26
| 2. **Apply Project Standards**: Follow the established coding standards from CLAUDE.md including: | ||
|
|
||
| - Use ES modules with proper import sorting and extensions | ||
| - Prefer `function` keyword over arrow functions | ||
| - Use explicit return type annotations for top-level functions | ||
| - Follow proper React component patterns with explicit Props types | ||
| - Use proper error handling patterns (avoid try/catch when possible) | ||
| - Maintain consistent naming conventions | ||
|
|
There was a problem hiding this comment.
Bug: The code-simplifier agent's instructions contain hardcoded JavaScript/TypeScript standards that will be incorrectly applied to code of any language, as the reference to CLAUDE.md is misleading.
Severity: HIGH
Suggested Fix
Update the code-simplifier.md instructions. Either make the coding standards generic, add language detection to apply them conditionally only to JS/TS files, or remove the misleading reference to CLAUDE.md and the language-specific rules.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: plugins/sentry-skills/agents/code-simplifier.md#L18-L26
Potential issue: The `code-simplifier.md` instructs an autonomous agent to apply coding
standards supposedly from `CLAUDE.md`. However, these standards (e.g., ES modules, React
patterns) are not in `CLAUDE.md` and are specific to JavaScript/TypeScript. The agent
will fall back to applying these hardcoded rules to any modified code file, regardless
of its language. This will cause incorrect refactoring suggestions on non-JS/TS code,
such as Python or Go, in Sentry's multi-language projects.
Did we get this right? 👍 / 👎 to inform future reviews.
JoshFerge
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
deslopskill with a more comprehensivecode-simplifierskill to improve code readability and simplify complex logic.The
code-simplifierskill expands upon thedeslopskill's functionality by not only removing AI-generated patterns but also providing guidelines for simplifying nested conditionals, complex boolean expressions, and unnecessary abstractions, ensuring a more robust approach to code quality.Slack Thread