fit-params : Handle n_ctx 0 for models that entirely fit with n_ctx_train #18890
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During initial fitting, if the n_ctx is 0, try to fit using n_ctx_train.
If initial fitting was successful, make sure to set n_ctx to n_ctx_train instead of leaving it at zero.
This could be done differently, but this approach avoids making cparams mutable deeper in the stack, and then having to clean it back to 0 if we aren't going to early return.
Fixes #18889