-
Notifications
You must be signed in to change notification settings - Fork 14.5k
HIP: add mmf for CDNA #18896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
HIP: add mmf for CDNA #18896
Conversation
|
Add lds 128 version, similar to lds 64. MUL_MAT_ID
|
|
Hello @JohannesGaessler , Just revert lds 128 as little perf improvement, this PR is ready for review but need some basic tuning. As I only have limited time to access MI300X, I need to ensure the model first, are llama-8b and granite-3.1-1b enough? Thank you. Only tested on CDNA3, could you have a test on your CDNA2 and CDNA1 if possible? If you don't have enough resource, I will only enable it on CDNA3. Best Regards |
Add mmf for CDNA, CDNA3 is passed, it will be very helpful if anyone can test it on CDNA2 and CDNA1, thank you.
- [x] Extend tile size to support shared memory loading 128.Attach the perf data, looks like that MUL_MAT cannot reach mmf no matter on CDNA or RDNA now, not sure why.
MUL_MAT_ID