ggml-rpc: Add graceful error handling for graph compute operations #18933
+39
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current RPC implementation crashes the server with
GGML_ASSERTwhenggml_backend_graph_computereturns a non-success status. This causes distributed inference setups to fail completely when a single worker encounters a temporary error (memory pressure, backend issues, etc.).Changes
Added response structs for
RPC_CMD_GRAPH_COMPUTEandRPC_CMD_GRAPH_RECOMPUTE:rpc_msg_graph_compute_rspwithint32_t statusrpc_msg_graph_recompute_rspwithint32_t statusServer-side changes:
GGML_ASSERT(status == GGML_STATUS_SUCCESS)with graceful error loggingggml_statusback to the client via RPC responseClient-side changes:
ggml_backend_rpc_graph_computenow receives and returns the actual status from the serverBefore
After
Related Issues
Testing
Tested in a Kubernetes distributed inference setup with 2 RPC workers: