Skip to content

Conversation

@xcrsz
Copy link
Contributor

@xcrsz xcrsz commented Nov 16, 2025

Summary by Sourcery

Enhancements:

  • Invoke patch_loader_conf_d in the gershwin.sh setup sequence

@xcrsz xcrsz requested review from a team as code owners November 16, 2025 12:14
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR amends the gershwin.sh setup sequence by inserting a call to patch_loader_conf_d, ensuring loader configuration files are properly patched during system initialization.

Sequence diagram for updated gershwin.sh setup process

sequenceDiagram
    participant S as "gershwin.sh script"
    S->>S: patch_etc_files()
    S->>S: patch_loader_conf_d()
    S->>S: community_setup_liveuser_gershwin()
    S->>S: community_setup_autologin_gershwin()
    S->>S: lightdm_setup()
Loading

File-Level Changes

Change Details Files
Invoke patch_loader_conf_d during gershwin.sh initialization
  • Added patch_loader_conf_d invocation after patch_etc_files in the setup sequence
desktop_config/gershwin.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Development Tracker Nov 16, 2025
@ericbsd ericbsd merged commit ad67fd2 into ghostbsd:master Nov 16, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Tracker Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants