Use floater props target element to be able to change the tooltip location #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Author
|
Hi @gilbarbara, Can you please review this PR and help me resolve all the checks? |
9 tasks
techanvil
added a commit
to google/site-kit-wp
that referenced
this pull request
Dec 8, 2025
…-joyride#1134. This allows tour tooltips to target an element within the highlighted area for a step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came up with a product requirement that I have to show tooltip on a specific element within a spotlight box. So I saw that there is prop name
floaterPropsthat accepts a target string but it is not being used in the package.So my changes will check if
targetprop is given in thefloaterPropsthen use it otherwise use the parenttarget(spotlight box).