Skip to content

test(context): fix nil context in TestHasRequestContext #4374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(context): fix nil context in TestHasRequestContext #4374

wants to merge 1 commit into from
+1 −1

Conversation

@sanbei101
Copy link

  • Testing improvements:
    • Replaces a nil context with context.TODO() in a call to http.NewRequestWithContext within TestHasRequestContext, ensuring a valid context is used for testing.

@appleboy appleboy changed the title test: fix nil context in TestHasRequestContext test(context): fix nil context in TestHasRequestContext Sep 26, 2025
@appleboy appleboy added the test label Sep 26, 2025
@appleboy appleboy added this to the v1.12 milestone Sep 26, 2025
@appleboy
Copy link
Member

@sanbei101 Please fix the lint error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

2 participants

@sanbei101 @appleboy