Use sigstore/policy-controller and update trust-policies #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the GitHub-maintained fork of the policy-controller Helm chart and updates installation instructions to use the official Sigstore chart. For GitHub-provided trust policies to function correctly with the upstream policy controller, the insecureIgnoreSCT: true configuration is now required and has been added to the GitHub trust policy.
- Remove the entire
policy-controllerchart from the repository - Update trust-policies chart to include
insecureIgnoreSCT: truefor GitHub keyless configuration - Update installation instructions to reference the upstream Sigstore chart
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/trust-policies/templates/clusterimagepolicy-github.yaml | Adds insecureIgnoreSCT configuration for GitHub keyless verification |
| charts/trust-policies/Chart.yaml | Bumps chart version to v0.7.0 |
| charts/policy-controller/* | Complete removal of the forked policy-controller chart |
| README.md | Updates installation instructions to use upstream Sigstore chart |
| .github/workflows/* | Updates CI/CD workflows to reference upstream chart |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
policy-controllerHelm chart (that leverages the fork of sigstore/policy-controller) and related documentation from the repository, updates installation instructions to reference the upstream Sigstore chart, and adjusts release and test workflows to reflect these changes. The primary focus is on deprecating the temporary fork and transitioning users to the official Sigstorepolicy-controllerchart.For the github provided trust-policies to work,
insecureIgnoreSCT: truemust be set. This was not necessary when using the GitHub fork of policy-controller due to it being set if using keyless directly in the policy-controller.