-
Notifications
You must be signed in to change notification settings - Fork 413
Use Node fs APIs instead of del
#3250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the del package dependency and replaces all its usages with Node's native fs.promises.rm API. This simplifies the codebase by eliminating an external dependency in favor of built-in functionality.
Key changes:
- Removed
delpackage from dependencies inpackage.json - Replaced all
del.deleteAsync()calls withfs.promises.rm()across TypeScript source files - Updated the compiled JavaScript files in
lib/directory to reflect these changes
Reviewed Changes
Copilot reviewed 11 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed del dependency from dependencies list |
| src/util.ts | Replaced del.deleteAsync() with fs.promises.rm() in withTmpDir, bundleDb, and cleanUpGlob functions |
| src/debug-artifacts.ts | Replaced del.deleteAsync() with fs.promises.rm() in createPartialDatabaseBundle function |
| src/codeql.test.ts | Replaced del.deleteAsync() with fs.promises.rm() in test cleanup code |
| src/analyze.ts | Replaced del.deleteAsync() with fs.promises.rm() in runFinalize function |
| lib/*.js | Auto-generated JavaScript reflecting the TypeScript changes |
esbena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a very minor semantic concern.
esbena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but conflicts
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
analysis-kinds: code-scanning).analysis-kinds: code-quality).upload-sarif).How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist