Skip to content

Conversation

@henrymercer
Copy link
Contributor

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

  • Advanced setup - Impacts users who have custom workflows.
  • Default setup - Impacts users who use default setup.
  • Code Scanning - Impacts Code Scanning (i.e. analysis-kinds: code-scanning).
  • Code Quality - Impacts Code Quality (i.e. analysis-kinds: code-quality).
  • Third-party analyses - Impacts third-party analyses (i.e. upload-sarif).
  • GHES - Impacts GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner October 28, 2025 13:03
Copilot AI review requested due to automatic review settings October 28, 2025 13:03
@github-actions github-actions bot added the size/S Should be easy to review label Oct 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the del package dependency and replaces all its usages with Node's native fs.promises.rm API. This simplifies the codebase by eliminating an external dependency in favor of built-in functionality.

Key changes:

  • Removed del package from dependencies in package.json
  • Replaced all del.deleteAsync() calls with fs.promises.rm() across TypeScript source files
  • Updated the compiled JavaScript files in lib/ directory to reflect these changes

Reviewed Changes

Copilot reviewed 11 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Removed del dependency from dependencies list
src/util.ts Replaced del.deleteAsync() with fs.promises.rm() in withTmpDir, bundleDb, and cleanUpGlob functions
src/debug-artifacts.ts Replaced del.deleteAsync() with fs.promises.rm() in createPartialDatabaseBundle function
src/codeql.test.ts Replaced del.deleteAsync() with fs.promises.rm() in test cleanup code
src/analyze.ts Replaced del.deleteAsync() with fs.promises.rm() in runFinalize function
lib/*.js Auto-generated JavaScript reflecting the TypeScript changes

Copy link
Contributor

@esbena esbena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a very minor semantic concern.

esbena
esbena previously approved these changes Oct 28, 2025
Copy link
Contributor

@esbena esbena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but conflicts

@henrymercer henrymercer enabled auto-merge October 28, 2025 15:28
@henrymercer henrymercer merged commit 8cc18ac into main Oct 28, 2025
243 checks passed
@henrymercer henrymercer deleted the henrymercer/prefer-fs-delete branch October 28, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Should be easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants