Java: Remove old SSA consistency queries. #20700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
There was a problem hiding this comment.
Pull Request Overview
This PR removes four obsolete SSA consistency query files that have been superseded by a consolidated consistency query file (java/ql/consistency-queries/SsaConsistency.ql). The removal eliminates redundant validation logic while maintaining SSA consistency checking through the newer, centralized implementation.
Key Changes:
- Removed four SSA consistency query files that are no longer needed
- Eliminates duplicate validation logic for SSA variables
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| java/ql/src/meta/ssa/UseWithoutUniqueSsaVariable.ql | Removed query checking for variable uses without unique SSA variables |
| java/ql/src/meta/ssa/UncertainDefWithoutPrior.ql | Removed query validating uncertain SSA updates have prior definitions |
| java/ql/src/meta/ssa/TooFewPhiInputs.ql | Removed query ensuring phi nodes have at least two inputs |
| java/ql/src/meta/ssa/AmbiguousToString.ql | Removed query checking for unique toString() on SSA variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hvitved
previously approved these changes
Oct 27, 2025
hvitved
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by
java/ql/consistency-queries/SsaConsistency.ql