Add state metadata fields to get_discussion tool #1305
+141
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes github#1303 The get_discussion tool was missing important state metadata that's already available in get_issue. Added four fields to provide complete discussion status information: - state: Current discussion state (OPEN/CLOSED) - isAnswered: Whether the discussion has an accepted answer - answeredAt: Timestamp when answer was provided - answerChosenAt: Timestamp when answer was selected Changed GetDiscussion to return a map instead of github.Discussion struct since the go-github library doesn't include all these fields in its type definition. This approach is consistent with other functions in this codebase (ListDiscussions, GetDiscussionComments). All tests pass and linter checks pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1303
Problem
The
get_discussiontool was missing important state metadata fields that are already available in theget_issuetool, making it difficult to determine discussion status.Solution
Added four state metadata fields to the
get_discussiontool:state- Discussion state (OPEN, CLOSED, etc.)isAnswered- Whether the discussion has an accepted answeransweredAt- Timestamp when the answer was provided (optional)answerChosenAt- Timestamp when the answer was selected (optional)Implementation
Modified
GetDiscussionto return these fields using amap[string]interface{}response instead of thegithub.Discussionstruct, since go-github v74'sDiscussiontype doesn't include theisAnsweredandansweredAtfields.This approach is consistent with existing functions in this codebase:
ListDiscussionsuses map response (discussions.go:244)GetDiscussionCommentsuses map response (discussions.go:448)All discussion-related tools now follow the same pattern due to GraphQL API limitations in the go-github library.
Changes
NodeFragmentstruct with new fieldsGetDiscussionGraphQL query to fetch state metadataTesting
All tests pass with updated snapshots. Linter reports no issues. Verified backward compatibility with existing
discussion functions.