Skip to content

Conversation

@elrayle
Copy link
Collaborator

@elrayle elrayle commented May 21, 2025

Description

This PR also adds the ability to force tests to run in the test.yaml workflow. This workflow gets stuck sometimes when triggered by PRs. Adding workflow_dispatch avoids the need to do a minor change (e.g. adding whitespace to a file) just to get the tests to run again.

Copilot AI review requested due to automatic review settings May 21, 2025 13:57
@elrayle elrayle requested a review from dangoor as a code owner May 21, 2025 13:57
@elrayle elrayle merged commit 2eec2fd into main May 21, 2025
5 checks passed
@elrayle elrayle deleted the elr/dispatch_tests branch May 21, 2025 14:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables manual triggering of the test workflow to recover from occasional stuck runs in PR builds.

  • Added workflow_dispatch trigger for manual reruns

push:
branches: [main]
pull_request: {}
workflow_dispatch: # Sometimes tests get stuck in PRs; This allows them to be rerun manually
Copy link

Copilot AI May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider moving the comment to its own line and simplifying it for clarity, e.g.: # Allows manual re-run when PR-triggered tests get stuck

Suggested change
workflow_dispatch: # Sometimes tests get stuck in PRs; This allows them to be rerun manually
# Allows manual re-run when PR-triggered tests get stuck
workflow_dispatch:

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants