Skip to content

Remove duplicate enum #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

Remove duplicate enum #4085

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3476419
Remove duplicate enum
robertbrignull Jul 22, 2025
95cb221
Fix linting
robertbrignull Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions extensions/ql-vscode/src/query-history/query-history-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ import type { QueryRunner } from "../query-server";
import type { VariantAnalysisManager } from "../variant-analysis/variant-analysis-manager";
import type { VariantAnalysisHistoryItem } from "./variant-analysis-history-item";
import { getTotalResultCount } from "../variant-analysis/shared/variant-analysis";
import { HistoryTreeDataProvider } from "./history-tree-data-provider";
import {
HistoryTreeDataProvider,
SortOrder,
} from "./history-tree-data-provider";
import type { QueryHistoryDirs } from "./query-history-dirs";
import type { QueryHistoryCommands } from "../common/commands";
import type { App } from "../common/app";
Expand Down Expand Up @@ -98,15 +101,6 @@ const SHOW_QUERY_TEXT_QUICK_EVAL_MSG = `\

`;

enum SortOrder {
NameAsc = "NameAsc",
NameDesc = "NameDesc",
DateAsc = "DateAsc",
DateDesc = "DateDesc",
CountAsc = "CountAsc",
CountDesc = "CountDesc",
}

/**
* Number of milliseconds two clicks have to arrive apart to be
* considered a double-click.
Expand Down
Loading