Convert from setuptools to flit-core + check-sdist #1223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
kurtmckee
requested changes
Dec 24, 2025
- Switch from setuptools to flit-core as a build backend - Setup check-sdist to ensure that build contents are well controlled - Explicitly exclude tests and dev tooling from builds (ensuring we build a minimal package; redistributors should use the source repo) - Update the 'twine-check' job to a 'check-package-data' job instead
- Set the interpreter version for the check-package-data tox env to 3.10 (3.9 would be ideal but conflicts with some deps) - Set `--strict` in `twine check` - Build in the tox envdir and use `recreate = true` to ensure it's always a clean build with no cached dependencies - Implement a "minimum" factor which pins the build backend version (`flit-core==3.11`) via a constraints file, which is created ephemerally inside of the tox env Co-authored-by: Kurt McKee <[email protected]>
sirosen
force-pushed
the
switch-to-flit-core-and-check-sdist
branch
from
3017c96 to
c00d3e5
Compare
Rather than using `PIP_CONSTRAINT`, do the builds with `--no-isolation` to guarantee that we are controlling the environment. Because under `tox-uv` it is possible to have a test environment where `pip` is not available, the `PIP_CONSTRAINT` technique is not guaranteed to be effective.
kurtmckee
approved these changes
Dec 29, 2025
kurtmckee
reviewed
Dec 29, 2025
| commands = python scripts/ensure_min_python_is_tested.py | ||
|
|
||
| [testenv:twine-check] | ||
| [testenv:check-package-data{,-minimum}] |
Member
There was a problem hiding this comment.
One thing that occurs to me is that it would be nice for this to be added to the env_list so that it runs locally as well, but my approval for this PR still stands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to
flit-coremoves us to a more modern but very minimal backend (flit-coreis considered the simplest production-ready PEP 517 backend and has no dependencies).This change allows us to establish some tighter control over our build process, but driven by
check-sdist, which is configured to verify our includes/excludes.Although debatable, this change makes the decision to strip out the various testing and linting tools from the builds. (
tox.ini,tests/*, etc)The rationale is that slimmer builds install faster (good) and that redistributors should always be working from the source repo anyway (so that they are not trusting our builds, Trusted Publishing notwithstanding).
Changes:
check-sdist(this could be moved to a separate tox env if preferable)I hesitated about not including a changelog for this, but for 99% of users the impact is nil.
Therefore, there is no changelog entry. One can be added on request during review.
Not included: this does not yet configure reproducible builds, but flit-core does support this as long as
SOURCE_DATE_EPOCHis set. That is intended as a small fast-follow.