Feature: Detect Uninitialized Variables Uses #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunsecode
force-pushed
the
feature/gilpass/detect-uninitialized-pass
branch
from
665d149 to
77c5f4f
Compare
yunsecode
requested review from
badermarouan and
jeremyelalouf
as code owners
yunsecode
force-pushed
the
feature/gilpass/detect-uninitialized-pass
branch
from
526f163 to
aff5dfb
Compare
Snowy1803
changed the title
yunsecode
force-pushed
the
feature/gilpass/detect-uninitialized-pass
branch
from
21df82e to
55396eb
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds uninitialized variable detection to the Glu compiler through a new GIL optimization pass. The pass tracks memory initialization states across control flow to catch uses of uninitialized variables at compile time.
- Implements a
DetectUninitializedPassthat performs dataflow analysis to track memory initialization states - Refactors
glu_createConstantStringto use aggregate initialization syntax - Adds comprehensive functional tests covering various control flow scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
lib/Optimizer/GILPasses/DetectUninitializedPass.cpp |
New pass implementation with dataflow analysis for tracking uninitialized memory |
stdlib/defaultImports/stringType.glu |
Refactored to use aggregate initialization syntax |
test/functional/run/use_unitialized_var.glu |
Comprehensive test suite with multiple control flow scenarios |
lib/Optimizer/CMakeLists.txt |
Adds new pass to build system |
include/Optimizer/GILPasses.def |
Registers new pass in pass manager |
yunsecode
force-pushed
the
feature/gilpass/detect-uninitialized-pass
branch
from
3f63d0f to
103860f
Compare
Snowy1803
previously approved these changes
Nov 7, 2025
Contributor
Snowy1803
left a comment
Snowy1803
left a comment
There was a problem hiding this comment.
It's some magic that I can't understand
Snowy1803
reviewed
Nov 12, 2025
Snowy1803
force-pushed
the
feature/gilpass/detect-uninitialized-pass
branch
from
033afdc to
38a2547
Compare
Snowy1803
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #488