Skip to content

Add basic CI via GitHub actions. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2025
Merged

Add basic CI via GitHub actions. #37

merged 1 commit into from
Nov 8, 2025

Conversation

@ivucica
Copy link
Member

@ivucica ivucica commented Nov 8, 2025

See #36

@ivucica ivucica self-assigned this Nov 8, 2025
@ivucica ivucica linked an issue Nov 8, 2025 that may be closed by this pull request
Run gnustep-web-install-dev as part of CI #36
Closed
@ivucica
Copy link
Member Author

ivucica commented Nov 8, 2025

This is not correct. This needs to be run using just the base script.

@ivucica ivucica force-pushed the 36-run-gnustep-web-install-dev-as-part-of-ci branch 2 times, most recently from bdbdec2 to 863ae79 Compare November 8, 2025 19:42
@ivucica ivucica marked this pull request as ready for review November 8, 2025 19:47
@ivucica
Add basic CI via GitHub actions.
e440407 
Additionally:

* Allow disabling setting up root password or sudo command wrangling
  (used in CI environment, but could be used by the end user via the
  MANAGE_SUDO environment variable).
* gnustep-web-install and gnustep-web-install-dev also detect if they
  are run inside a working copy, assume this is CI environment, and
  skip cloning the repo itself.
* Only gnustep-web-install (non-dev) is run in CI for now, as the
  dev version assumes ssh keys are set up to access private repos.
  This could be arranged in GitHub Actions, but is left for future
  improvement.

No attempt was made to cache any part of the installation between runs,
since we are trying to run the entire installation process as a test.
It would be useful to have a smoke test that just verifies portions of
the build, or to produce a custom container image that has at least
the base dependencies installed. Then the full run could be performed
on-demand. However, adjusting the script to run in such phases is
better left for a future improvement.

No attempt is done yet to improve failure wrangling (e.g. make the
scripts exit more often on errors, which is useful for CI).

No attempt is made to run on multiple OS versions or architectures.

Fixes #36.
@ivucica ivucica force-pushed the 36-run-gnustep-web-install-dev-as-part-of-ci branch from 863ae79 to e440407 Compare November 8, 2025 19:58
@ivucica
Copy link
Member Author

ivucica commented Nov 8, 2025

This is known to fail because the underlying scripts are broken. The changes in this PR are not really the problem. Breakage is the correct state.

Additional note: -dev version of the script is documented in the README, but if a user is expecting to just get ~some GNUstep running out of the box, then they should be running non--dev version of the script since they don't necessarily have the .ssh keys set up. Therefore I have not made an effort to make the -dev script work, which clones repos using SSH keys. (Besides, devs could/should have the insteadOf option in their .gitconfig set up, to override the unauthenticated clone URLs, rather than pushing out the authenticated clone URLs on users. The -dev script should only differ in the amount of code it tries to build, ideally.)

@ivucica ivucica merged commit e440407 into master Nov 8, 2025
1 check failed
@ivucica ivucica deleted the 36-run-gnustep-web-install-dev-as-part-of-ci branch November 8, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ivucica ivucica

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run gnustep-web-install-dev as part of CI

2 participants

@ivucica