fix(schema): workaround IntelliJ JSON Schema validation bug #2576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntelliJ/PhpStorm has a bug (IJPL-63564) where it incorrectly validates
YAML files against JSON schemas that use `oneOf` with `required` constraints.
This causes false positive "property 'for' is not allowed" warnings.
Changes:
- Split `for_cmds_call` into `for_cmd_call` and `for_task_call`
Each definition now has its own `required` array instead of using
`oneOf: [{ required: ["cmd"] }, { required: ["task"] }]`
- Fix bug in `for_deps_call` where `oneOf` referenced non-existent
`cmd` property (deps can only call tasks, not commands)
The schema remains semantically equivalent - the `additionalProperties: false`
on each split definition ensures mutual exclusivity of cmd/task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix IntelliJ JSON Schema validation by splitting
for_cmds_callinto separatefor_cmd_callandfor_task_calldefinitions.IntelliJ's JSON Schema validator has issues with
oneOfcombined with partially overlapping schemas, causingforloops to not be recognized (see IJPL-63564 and IJPL-63680).This change replaces the
oneOfpattern with explicit separate schema definitions forfor+cmdandfor+taskcombinations.Test plan
forloops