-
Notifications
You must be signed in to change notification settings - Fork 30
feat(test reports): test_report key functionality #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your project check has failed because the head coverage (56.65%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
========================================
Coverage 56.65% 56.65%
========================================
Files 634 638 +4
Lines 35412 35514 +102
========================================
+ Hits 20064 20122 +58
- Misses 14719 14759 +40
- Partials 629 633 +4
🚀 New features to boost your workflow:
|
| @@ -0,0 +1,62 @@ | |||
| package types | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Missed header for check (goheader)
| @@ -0,0 +1,54 @@ | |||
| package pipeline | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Missed header for check (goheader)
| @@ -0,0 +1,29 @@ | |||
| package pipeline | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Missed header for check (goheader)
| Pull string `json:"pull,omitempty" yaml:"pull,omitempty"` | ||
| Ruleset Ruleset `json:"ruleset,omitempty" yaml:"ruleset,omitempty"` | ||
| Secrets StepSecretSlice `json:"secrets,omitempty" yaml:"secrets,omitempty"` | ||
| TestReport TestReport `json:"test_report,omitempty" yaml:"test_report,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
tag is not aligned, should be: json:"test_report,omitempty" yaml:"test_report,omitempty" (tagalign)
| // | ||
| // swagger:model PipelineTestReport | ||
| TestReport struct { | ||
| Results []string `yaml:"results,omitempty" json:"results,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
tag is not aligned, should be: yaml:"results,omitempty" json:"results,omitempty" (tagalign)
|
|
||
| // TestReport represents the structure for test report configuration. | ||
| type TestReport struct { | ||
| Results []string `yaml:"results,omitempty" json:"results,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
tag is not aligned, should be: yaml:"results,omitempty" json:"results,omitempty" (tagalign)
| func (t *TestReport) UnmarshalYAML(unmarshal func(interface{}) error) error { | ||
| // test report we try unmarshalling to | ||
| testReport := new(struct { | ||
| Results []string `yaml:"results,omitempty" json:"results,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
tag is not aligned, should be: yaml:"results,omitempty" json:"results,omitempty" (tagalign)
| len(step.Parameters) == 0 && len(step.Secrets) == 0 && | ||
| len(step.Template.Name) == 0 && !step.Detach { | ||
| len(step.Template.Name) == 0 && len(step.TestReport.Results) == 0 && | ||
| len(step.TestReport.Attachments) == 0 && !step.Detach { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
unnecessary leading newline (whitespace)
No description provided.