Skip to content

Conversation

@KellyMerrick
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 57.69231% with 44 lines in your changes missing coverage. Please review.

Project coverage is 56.65%. Comparing base (d9df783) to head (0f333ac).

Files with missing lines Patch % Lines
api/types/test_report.go 0.00% 26 Missing ⚠️
compiler/types/yaml/buildkite/test_report.go 70.37% 7 Missing and 1 partial ⚠️
api/types/pipeline.go 57.14% 4 Missing and 2 partials ⚠️
compiler/types/yaml/yaml/test_report.go 86.36% 2 Missing and 1 partial ⚠️
compiler/types/yaml/buildkite/step.go 50.00% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (56.65%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #1278    +/-   ##
========================================
  Coverage   56.65%   56.65%            
========================================
  Files         634      638     +4     
  Lines       35412    35514   +102     
========================================
+ Hits        20064    20122    +58     
- Misses      14719    14759    +40     
- Partials      629      633     +4     
Files with missing lines Coverage Δ
compiler/native/validate.go 100.00% <100.00%> (ø)
compiler/types/pipeline/container.go 82.98% <100.00%> (+0.07%) ⬆️
compiler/types/pipeline/test_report.go 100.00% <100.00%> (ø)
compiler/types/yaml/yaml/secret.go 87.74% <ø> (ø)
compiler/types/yaml/yaml/step.go 95.77% <100.00%> (+0.06%) ⬆️
mock/server/pipeline.go 0.00% <ø> (ø)
compiler/types/yaml/buildkite/step.go 64.76% <50.00%> (-0.29%) ⬇️
compiler/types/yaml/yaml/test_report.go 86.36% <86.36%> (ø)
api/types/pipeline.go 97.52% <57.14%> (-2.48%) ⬇️
compiler/types/yaml/buildkite/test_report.go 70.37% <70.37%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -0,0 +1,62 @@
package types
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Missed header for check (goheader)

@@ -0,0 +1,54 @@
package pipeline
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Missed header for check (goheader)

@@ -0,0 +1,29 @@
package pipeline
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Missed header for check (goheader)

Pull string `json:"pull,omitempty" yaml:"pull,omitempty"`
Ruleset Ruleset `json:"ruleset,omitempty" yaml:"ruleset,omitempty"`
Secrets StepSecretSlice `json:"secrets,omitempty" yaml:"secrets,omitempty"`
TestReport TestReport `json:"test_report,omitempty" yaml:"test_report,omitempty"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
tag is not aligned, should be: json:"test_report,omitempty" yaml:"test_report,omitempty" (tagalign)

//
// swagger:model PipelineTestReport
TestReport struct {
Results []string `yaml:"results,omitempty" json:"results,omitempty"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
tag is not aligned, should be: yaml:"results,omitempty" json:"results,omitempty" (tagalign)


// TestReport represents the structure for test report configuration.
type TestReport struct {
Results []string `yaml:"results,omitempty" json:"results,omitempty"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
tag is not aligned, should be: yaml:"results,omitempty" json:"results,omitempty" (tagalign)

func (t *TestReport) UnmarshalYAML(unmarshal func(interface{}) error) error {
// test report we try unmarshalling to
testReport := new(struct {
Results []string `yaml:"results,omitempty" json:"results,omitempty"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
tag is not aligned, should be: yaml:"results,omitempty" json:"results,omitempty" (tagalign)

len(step.Parameters) == 0 && len(step.Secrets) == 0 &&
len(step.Template.Name) == 0 && !step.Detach {
len(step.Template.Name) == 0 && len(step.TestReport.Results) == 0 &&
len(step.TestReport.Attachments) == 0 && !step.Detach {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
unnecessary leading newline (whitespace)

@KellyMerrick KellyMerrick changed the title feat(test reports): adding test report functionality feat(test reports): test_report key functionality Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants