This repository was archived by the owner on Apr 1, 2025. It is now read-only.
fix: re-add option to switch off unique mapping keys enforcement #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
|
Author
|
@niemeyer could I get some eyes on this ? That'd be much appreciated 🙇🏼 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially reverts 309c9d1 while keeping unique mapping keys enforcement as default behaviour for
Unmarshal.The rationale is that libraries like
ghodss/yamlrelies onuniqueKeysbeing set tofalse. Giving the possibility to do so would allow the upgrade ofgo-yamltov3without introducing breaking changes.