Fix for testing plugins with older stable releases #2416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a plugins last stable release is older than the last Dalamud API version, it wouldn't be shown in the Plugin installer, even if there is a testing version available for the current Dalamud API version.
This is currently happening for Quest Tracker (manifest), which has a DalamudApiLevel of 11, but a TestingDalamudApiLevel of 13.
There are two issues that come into play:
PluginInstallerWindow.IsManifestFilteredwould filter out plugins that didn't match the current API level. This is redundant in my opinion, since the API version is checked inPluginManager.IsManifestEligiblewhen the plugin repository loads.PluginManager.IsManifestEligiblefunction on the other hand only checked theTestingDalamudApiLevelif the user already has opted in to testing of this plugin. I changed it so that the specific plugin testing opt-in state is not taken into consideration.For convenience, I moved
RemotePluginManifest.IsAvailableForTestingup toIPluginManifest, implemented by the base classPluginManifest. With that, the functionPluginManager.HasTestingVersionhas been removed.