Default-param _ex functions on builtins
#1424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
quality-of-life
Bromeon
changed the title
_ex functions on builtins
Bromeon
force-pushed
the
feature/builtin-ex-builders
branch
from
a3e5cfd to
0e584e5
Compare
Bromeon
force-pushed
the
feature/builtin-ex-builders
branch
from
0e584e5 to
a18c1da
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1424 |
Bromeon
force-pushed
the
feature/builtin-ex-builders
branch
from
a18c1da to
1879ddc
Compare
Bromeon
force-pushed
the
feature/builtin-ex-builders
branch
from
1879ddc to
f0eb7f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, builtin types did not use the
*_exmethod +Ex*builder struct pattern to emulate default parameters. Instead, we've used a patchwork of different API styles to accomodate this. This causes quite a bit of inconsistency, requiring users to learn the specifics of each builtin API, while also making it easy for us to forget new additions in Godot (methods + parameters).This PR changes the approach and adopts the
*_exmethod pattern from the class APIs. We can write our own APIs whenever we find more idiomatic APIs, but for many methods (especially inGString+StringName), there's not much point.Note that the current set of APIs is a first draft, which we can refine until the v0.5 release (even once merged). Would be good to collect some feedback on the
masterversion.Closes #1335.