Strip VoxelGIData and LightmapGIData using placeholders for dedicated server exports #112744
+106
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
enhancement
topic:export
performance
bug
topic:rendering
topic:3d
and removed
performance
labels
5 tasks
Calinou
force-pushed
the
voxelgidata-lightmapgidata-add-placeholder
branch
3 times, most recently
from
c5fd4bb to
513085c
Compare
… server exports This greatly reduces PCK size for dedicated servers in projects that use either VoxelGI or LightmapGI for global illumination.
Calinou
force-pushed
the
voxelgidata-lightmapgidata-add-placeholder
branch
from
513085c to
17b7c2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly reduces PCK size for dedicated servers in projects that use either VoxelGI or LightmapGI for global illumination. Additionally, this prevents errors from being printed on export when using
--headlessto export a dedicated server PCK in a project that uses a VoxelGI node.The same approach can be used to implement godotengine/godot-proposals#12748 later on.
Edit: Done in #112773.
and Compress LightmapGIData, VoxelGIData and baked ArrayOccluder3D in the editor #103284.
Testing project: test_headless_voxelgi_export.zip
Preview
File sizes are in bytes. The test project includes a LightmapGI node with 16 probe subdivisions and a VoxelGI node with 128 subdivisions.
Before this PR, both PCK/ZIPs would be the same size as the project doesn't include any textures.
PCK size
ZIP size