-
-
Notifications
You must be signed in to change notification settings - Fork 23.8k
Add camera perspective projection mode for advanced import #92234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add camera perspective projection mode for advanced import #92234
Conversation
|
In the middle of review but wanted to mention this is a good proposal. |
4276312 to
b655dd7
Compare
b655dd7 to
1577e5c
Compare
|
I feel like you should be able to change the view from the popup itself. Having to close it and going to the settings for it to change it feels like it will result in the feature having 0 discoverability and ease of use. |
|
Thank you both👍🏻 yeah this makes sense. I will update the PR accordingly. |
|
I updated the code to be able to change the projection inside the camera view now. Here a video showcase: Bildschirmaufnahme.2024-05-26.um.01.10.39.movI would appreciate any feedback about the location of the button / if it should have an icon at all. With this implementation it would need two icons for both camera projection methods. To Note:
|
|
PatrickFlameLizard what are your thoughts on having two two-state toggles. We had the discussion about not using triple state toggles for the lights a few years ago. You can see in the video. |
|
@fire I don't think the video shows any triple state toggle: the camera always exists, so it is just a single boolean toggle: either ortho or perspective as far as UI, rather than a single button, we should aim to have the same menu as in the 3D scene view: Left/top/forward/bottom/etc, perspective/orthographic. See here for the menu layout I am talking about I don't expect one PR to necessarily add all these features, but perhaps if it is its own function maybe it would be easier/ better to copy the way the 3D view does things. |
|
@lyuma This sounds like a good idea👍🏻 that way it's already the same UX for the user. I will get on it |
|
@paddy-exe Bump 🙂 Have you been able to look into updating the PR according to lyuma's feedback recently? |
I have and I encountered a few bumps that I will need to resolve. They mostly stem from me not being familiar with that part of the codebase. I will be attending GodotCon and afterwards try to get back to it to get it in a mergeable state. |
1577e5c to
40e7fe5
Compare
40e7fe5 to
49e09d5
Compare

This PR adds the possibility to switch between the perspective and orthographic camera projection modes. It also adds a setting in
Editor/ImportwithPerspectivebeing the default.Closes godotengine/godot-proposals#6692
Showcase
Godot-PerspectiveCameraView-720p.mov