Skip to content

Conversation

@baembry-goog
Copy link
Collaborator

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Update AP2 specification with clarifications and flow diagram step corrections.

Based on partner feedback, this CL refines the definitions of Credentials Provider and Merchant Endpoint, adds details on merchant-forced user confirmation, and clarifies the accountability shift with a Cart Mandate. It also corrects several step numbers in the flow diagram explanation.

@baembry-goog baembry-goog requested a review from a team as a code owner October 10, 2025 00:39
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @baembry-goog, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the AP2 specification document by incorporating crucial clarifications and corrections based on partner feedback. The changes aim to enhance the precision of key definitions, elaborate on merchant-forced user confirmation processes, and adjust accountability with the introduction of a Cart Mandate. Additionally, it rectifies inconsistencies in the flow diagram's step numbering, ensuring the document is more accurate and easier to understand.

Highlights

  • Clarified Definitions: The definitions for 'User's Credentials Provider (CP)' and 'Remote or Merchant Endpoint (ME)' have been expanded to provide more precise descriptions of their roles and scope within the AP2 ecosystem.
  • Merchant-Forced User Confirmation: Detailed explanations have been added regarding scenarios where a merchant can force user confirmation, particularly when the request is not for a specific SKU, and how this mechanism impacts accountability.
  • Cart Mandate Accountability Shift: The documentation now explicitly states that a 'Cart Mandate' shifts accountability for a bad transaction towards the user, except in cases of clear merchant error.
  • Flow Diagram Step Corrections: Several step numbers referenced in the explanation of the flow diagram have been corrected to align accurately with the diagram's sequence.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides several useful clarifications to the AP2 specification, particularly around the definitions of ecosystem roles, merchant-forced confirmation, and accountability shifts. The corrections to the flow diagram step numbers are also helpful. I've found a minor formatting issue in the list of salient points for the flow diagram where a line of text was misplaced during the renumbering. My suggestions aim to correct this formatting to improve readability. Overall, these are great improvements to the documentation.

@joshlund-goog joshlund-goog merged commit 588cb1b into google-agentic-commerce:main Nov 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants