Introduce PedestalPolicy. #1583
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_810477225
branch
3 times, most recently
from
fa4de20 to
64e3997
Compare
copybara-service
bot
force-pushed
the
test_810477225
branch
13 times, most recently
from
6e9ca96 to
3de360a
Compare
copybara-service
bot
force-pushed
the
test_810477225
branch
13 times, most recently
from
53b9ba8 to
da909ae
Compare
copybara-service
bot
force-pushed
the
test_810477225
branch
3 times, most recently
from
a97b2f1 to
014cefe
Compare
copybara-service
bot
force-pushed
the
test_810477225
branch
5 times, most recently
from
97bdb0a to
facd202
Compare
Collaborator
|
Is this temporarily on hold? It would be broadly useful for self consistent pedestal models. |
copybara-service
bot
force-pushed
the
test_810477225
branch
6 times, most recently
from
66d6d31 to
8b9234c
Compare
copybara-service
bot
force-pushed
the
test_810477225
branch
13 times, most recently
from
22a5eb3 to
27b73ea
Compare
This is a step toward having full Martin scaling, where there will be a Martin scaling PedestalPolicy that ramps up and ramps down the pedestal height. This PR is just a step that defines the new stateful interface required for doing so and transitions the existing `set_pedestal` functionality to being implemented with the new PedestalPolicy class. PiperOrigin-RevId: 810477225
copybara-service
bot
force-pushed
the
test_810477225
branch
from
27b73ea to
7425b98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce PedestalPolicy.
This is a step toward having full Martin scaling, where there will be a
Martin scaling PedestalPolicy that ramps up and ramps down the pedestal
height. This PR is just a step that defines the new stateful interface
required for doing so and transitions the existing
set_pedestalfunctionality to being implemented with the new PedestalPolicy class.