Implement rotation rule for QLKNN transport models. #1739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_832337883
branch
2 times, most recently
from
d491333 to
bbd61a4
Compare
This follows the description of the rotation rule from the original QLKNN paper (van de Plassche K.L. 2020). The application of the rotation rule is gated by a flag that is false by default. Validation of this rule will be required for both QLKNN10D and QLKNN_7_11 before we can enable it by default. It is possible that the rule cannot be directly applied to QLKNN_7_11 and requires further work. PiperOrigin-RevId: 832337883
copybara-service
bot
force-pushed
the
test_832337883
branch
from
bbd61a4 to
c97bfba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement rotation rule for QLKNN transport models.
This follows the description of the rotation rule from the original QLKNN paper (van de Plassche K.L. 2020). The application of the rotation rule is gated by a flag that is false by default.
Validation of this rule will be required for both QLKNN10D and QLKNN_7_11 before we can enable it by default. It is possible that the rule cannot be directly applied to QLKNN_7_11 and requires further work.