Skip to content

Conversation

@qti-vaiskv
Copy link

No description provided.

@qti-vaiskv qti-vaiskv force-pushed the sme1/pqs8-qc8w-gemm-igemm branch 2 times, most recently from ae4bf78 to 6d89c3a Compare September 16, 2025 09:22
@qti-vaiskv qti-vaiskv force-pushed the sme1/pqs8-qc8w-gemm-igemm branch from 6d89c3a to ab26084 Compare October 23, 2025 09:03
@qti-vaiskv
Copy link
Author

Hi @dsharlet - can you please help review this PR

@qti-vaiskv qti-vaiskv force-pushed the sme1/pqs8-qc8w-gemm-igemm branch from ab26084 to e8b092c Compare October 23, 2025 09:37
@@ -741,6 +741,46 @@ std::vector<GemmTestParams> CreateTests2(


#if XNN_ENABLE_AVX512AMX && (XNN_ARCH_X86 || XNN_ARCH_X86_64)
INSTANTIATE_TEST_SUITE_P(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there so many unrelated changes in this file?

I checked at HEAD, it doesn't appear that this file is stale.

cc @fbarchard

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsharlet

Sorry, I used the generate-gemm-test.py to generate the test to wrong output file test/qs8-qc8w-igemm-minmax-fp32.cc.
For the SME2 the output file used was test/qs8-qc8w-igemm-minmax-fp32-3.cc. I have regenerated this file with SME1 test case. But still the generated file has unrelated changes. Not sure why this is happening.

To generate the file, I used the below command:

python tools/generate-gemm-test.py -s test/qs8-qc8w-igemm-minmax-fp32.yaml -o test/qs8-qc8w-igemm-minmax-fp32-3.cc

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct command can be found in this script (or just run the script): https://github.com/google/XNNPACK/blob/master/scripts/generate-tests.sh

@qti-vaiskv qti-vaiskv force-pushed the sme1/pqs8-qc8w-gemm-igemm branch from e8b092c to 05f7168 Compare October 31, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants