Support VK_EXT_shader_long_vector when Vulkan headers have it #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj2
approved these changes
Jan 22, 2026
dneto0
force-pushed
the
long-vector-ndk
branch
from
4e5cff1 to
c9bca20
Compare
Conditionally compile the support based on whether the Vulkan headers have the necessary definitions. Attempting to use the feature in an Amber script successfully parse the script but then fail to run, which is the intention. This should fix the Android NDK build. Even the latest NDK r29 does not have a new enough Vulkan header. Fixed: google#1102
dneto0
force-pushed
the
long-vector-ndk
branch
from
c9bca20 to
3e7c358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally compile the support based on whether the Vulkan headers have the necessary definitions. Attempting to use the feature in an Amber script successfully parse the script but then fail to run, which is the intention.
This should fix the Android NDK build.
Even the latest NDK r29 does not have a new enough Vulkan header.
Fixed: #1102