Standardize on the ID "attach-javadocs" for maven-javadoc-plugin.
#511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, our projects use a mix of that and "`attach-docs`." I think that the choice of ID is unlikely to make a difference in practice as long as we're consistent between a project and its parent (as was _not_ the case in jimfs prior to cl/814204365), but it's not hard to imagine messing things up someday if we copy and paste across projects. "`attach-javadocs`" does seem to be at least [some kind of recommendation](https://maven.apache.org/plugins/maven-javadoc-plugin/faq.html#:~:text=attach%2Djavadocs). Also, in Guava: In the `future` projects, remove some probably needless differences in configuration that we'd carried over from the main Guava projects back in the day: ``` <id>generate-javadoc-site-report</id> <phase>site</phase> ``` I already removed that configuration from the main Guava projects back in cl/572593797. RELNOTES=n/a PiperOrigin-RevId: 814338191
copybara-service
bot
force-pushed
the
test_814241768
branch
from
c2320b7 to
930d950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize on the ID "
attach-javadocs" formaven-javadoc-plugin.Currently, our projects use a mix of that and "
attach-docs." I think that the choice of ID is unlikely to make a difference in practice as long as we're consistent between a project and its parent (as was not the case in jimfs prior to cl/814204365), but it's not hard to imagine messing things up someday if we copy and paste across projects."
attach-javadocs" does seem to be at least some kind of recommendation.Also, in Guava: In the
futureprojects, remove some probably needless differences in configuration that we'd carried over from the main Guava projects back in the day:I already removed that configuration from the main Guava projects back in cl/572593797.
RELNOTES=n/a