Allow functions to memoize themselves without being added to the query group.#334
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Allow functions to memoize themselves without being added to the query group.#334copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
…y group. This, in turn, lets us dismantle the God Object so that we don't need one giant struct with every function we ever dispatch to. This, in turn, makes it potentially cheap and easy to use memoized functions from tests (we only need to set up the _inputs_), and makes it very simple to memoize expensive functions without refactoring all callers. (By convention, the first argument is always the db already!) I'm not sold on the exact syntax -- in fact, I think it needs some work, and we should make it a proc macro wrapper thing so that we can apply it as an attribute and let rustfmt work, and even maybe to methods. PiperOrigin-RevId: 860334587
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow functions to memoize themselves without being added to the query group.
This, in turn, lets us dismantle the God Object so that we don't need one giant struct with every function we ever dispatch to.
This, in turn, makes it potentially cheap and easy to use memoized functions from tests (we only need to set up the inputs), and makes it very simple to memoize expensive functions without refactoring all callers. (By convention, the first argument is always the db already!)
I'm not sold on the exact syntax -- in fact, I think it needs some work, and we should make it a proc macro wrapper thing so that we can apply it as an attribute and let rustfmt work, and even maybe to methods.