Categorize using Base::method; as a function.#381
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 3, 2026
Merged
Conversation
copybara-service
bot
force-pushed
the
test_863686581
branch
3 times, most recently
from
58f557f to
07d2c0f
Compare
This will help overload detection (once it iterates over unsupported items), as this is literally how you introduce a method from your base class into an overload set. ```c++ using Base::foo; // required to be added to the `foo` overload set introduced here void foo(int); // shadows Base::foo unless you have the `using` ``` Also, it reduces the number of errors with an unknown item categorization for aggregation purposes. After this change, the single only uncategorized item I could find on a test run was a namespace declaration. I guess I should add a new Category for that, and then I'll need to iterate over larger test codebases. PiperOrigin-RevId: 864997903
copybara-service
bot
force-pushed
the
test_863686581
branch
from
07d2c0f to
7bd0698
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Categorize
using Base::method;as a function.This will help overload detection (once it iterates over unsupported items), as this is literally how you introduce a method from your base class into an overload set.
Also, it reduces the number of errors with an unknown item categorization for aggregation purposes.
After this change, the single only uncategorized item I could find on a test run was a namespace declaration. I guess I should add a new Category for that, and then I'll need to iterate over larger test codebases.