Change Record.is_unsafe_type to Record.safety_annotation#389
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 3, 2026
Merged
Change Record.is_unsafe_type to Record.safety_annotation#389copybara-service[bot] merged 1 commit intomainfrom
Record.is_unsafe_type to Record.safety_annotation#389copybara-service[bot] merged 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_864525668
branch
2 times, most recently
from
ce4e844 to
d62a2d1
Compare
The type is now `SafetyAnnotation` instead of a plain bool, making it possible to distinguish between explicitly safe, explicitly unsafe, and unannotated. This is a clearer interface, and also makes `Record` more similar to `Function`. Updated the comment in `ir.h` to clarify that this field only describes the annotation; Crubit may still mark an unannotated type as unsafe. The `record_safety` function has been updated to respect the `SafetyAnnotation::DisableUnsafe` annotation. PiperOrigin-RevId: 865049355
copybara-service
bot
force-pushed
the
test_864525668
branch
from
d62a2d1 to
37c4248
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Record.is_unsafe_typetoRecord.safety_annotationThe type is now
SafetyAnnotationinstead of a plain bool, making it possibleto distinguish between explicitly safe, explicitly unsafe, and unannotated. This
is a clearer interface, and also makes
Recordmore similar toFunction.Updated the comment in
ir.hto clarify that this field only describes theannotation; Crubit may still mark an unannotated type as unsafe.
The
record_safetyfunction has been updated to respect theSafetyAnnotation::DisableUnsafeannotation.