Skip to content

Conversation

@Bobgy
Copy link
Collaborator

@Bobgy Bobgy commented Feb 27, 2022

Fixes #73

Assumption: the license URL we want to collect is always publically accessible
If there are concerns with this assumption, we can discuss several options:

  • hide the feature under a flag
  • enable validation by default, but provide a flag to disable this feature. Note we will be releasing v2, so we can consider making a breaking change if that's the default behavior we prefer.

@Bobgy Bobgy changed the title feat(v2): csv - validate license URL and guess more if invalid feat!(v2): csv - validate license URL and guess more if invalid Feb 28, 2022
@gwatts
Copy link
Contributor

gwatts commented May 8, 2025

@Bobgy any thoughts on updating this and merging? i have a project that is being tripped up by this issue; i think this is a reasonable approach to solve it

@gwatts
Copy link
Contributor

gwatts commented May 9, 2025

opened #328 as an alternative option to this pr that avoids using the network to check if the url is reachable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve robustness of linking to license on hosting website

2 participants