Use Character.charCount.
#8167
Merged
Use Character.charCount.
#8167
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see any discussion of why we didn't use this back in cl/8202370. It was added to Java [in Java 1.5](https://docs.oracle.com/en/java/javase/25/docs/api/java.base/java/lang/Character.html#charCount(int)), just like [the `isSupplementaryCodePoint` method](https://docs.oracle.com/en/java/javase/25/docs/api/java.base/java/lang/Character.html#isSupplementaryCodePoint(int)) that we've been using instead. Android has had it [since 1.0](https://developer.android.com/reference/java/lang/Character#charCount(int)) (though this code predates Android 1.0 by two weeks!), so there's no concern there. We didn't even expose the code to GWT at that point, either. RELNOTES=n/a PiperOrigin-RevId: 860359073
copybara-service
bot
force-pushed
the
test_860145053
branch
from
c969e94 to
53d1de0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Character.charCount.I don't see any discussion of why we didn't use this back in cl/8202370. It was added to Java in Java 1.5, just like the
isSupplementaryCodePointmethod that we've been using instead. Android has had it since 1.0 (though this code predates Android 1.0 by two weeks!), so there's no concern there. We didn't even expose the code to GWT at that point, either.RELNOTES=n/a