Follow up Remove Tensor from CGGI: Update the Emitters and tests #2278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes the following changes: * Uses linalg-to-affine-loops-tensor to lower linalg operations with tensor semantics * Convert yosys RTLIL to MLIR with tensor semantics * A few fixes to the secret dialect / patterns to handle secret vs plaintext tensors and insertion operations * Remove the option for submodule optimization in Yosys - it never worked quite well, and was suited mostly for memref semantics. I think if we want to invest in Yosys compilation more, we should separate that out into a separate pass that prepares the secret.generic functions so that yosys-optimizer isn't doing all these rewrites within its body PiperOrigin-RevId: 757889057
WoutLegiest
changed the title
Working secret-to-cggi tests Working Yosys tests Only e2e rust not working Add DenseAttr Emittion to VerilogEmitter
This PR makes the following changes: * Uses linalg-to-affine-loops-tensor to lower linalg operations with tensor semantics * Convert yosys RTLIL to MLIR with tensor semantics * A few fixes to the secret dialect / patterns to handle secret vs plaintext tensors and insertion operations * Remove the option for submodule optimization in Yosys - it never worked quite well, and was suited mostly for memref semantics. I think if we want to invest in Yosys compilation more, we should separate that out into a separate pass that prepares the secret.generic functions so that yosys-optimizer isn't doing all these rewrites within its body PiperOrigin-RevId: 757889057
Working secret-to-cggi tests Working Yosys tests Only e2e rust not working Add DenseAttr Emittion to VerilogEmitter
All test working again
j2kun
approved these changes
Oct 16, 2025
j2kun
added
the
pull_ready
|
Going to start the process of getting this through copybara |
j2kun
removed
the
pull_ready
|
Note, double check:
|
|
Yes! in the import for #2237 I had to fix those tests - I had to add some basic emitter support for some more ops (almost done) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup after #2237