Update GitHub Actions workflow to use Java 17. #2586
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also disables test_jre_cycles until cycle_finder runs on Java 17.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions workflow to use Java 17 instead of Java 11, addressing compatibility issues with the newer Java version. The change temporarily disables the test_jre_cycles test until the cycle_finder tool is updated to support Java 17.
Key Changes:
- Updated Java version from 11 to 17 in the CI workflow
- Temporarily disabled
test_jre_cyclestest due to cycle_finder incompatibility with Java 17
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Test command-line tools. | ||
| - name: test_tools | ||
| run: $MAKE_CMD JAVA_HOME=$JAVA_11_HOME test_translator test_cycle_finder test_jre_cycles | ||
| # Disable test_jre_cycles, as cycle_finder fails on Java 17 (https://github.com/tomball/j2objc/issues/1) |
There was a problem hiding this comment.
[nitpick] The comment references a temporary workaround but lacks context about when this will be addressed. Consider adding a TODO marker and an expected timeline or condition for re-enabling the test, e.g., 'TODO: Re-enable once cycle_finder supports Java 17 (tracking issue: #1)'.
Suggested change
| # Disable test_jre_cycles, as cycle_finder fails on Java 17 (https://github.com/tomball/j2objc/issues/1) | |
| # TODO: Re-enable test_jre_cycles once cycle_finder supports Java 17 (tracking issue: https://github.com/tomball/j2objc/issues/1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also disables test_jre_cycles until cycle_finder runs on Java 17.