-
Notifications
You must be signed in to change notification settings - Fork 333
adds aws_sigv4 signer for s3 requests, adds python s3 credentials #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@jbms Matt is working on figuring out what the CLA signing situation is in general at the Allen, but we would appreciate any feedback you have on this sooner rather than later. |
|
In general this looks fine --- I don't think there are many issues. |
|
Hi @MatthewAitken, thanks for implementing this. May I ask you for an MWE to use this? Here is what I tried, but I still get some permission error in the client:
Then in ipython |
Apologies for the delay getting back to finish this. You need to allow credentials (and replace mytoken with whatever token string you want) |
Co-authored-by: Emanuele Bezzi <[email protected]>
Todo: