feat(ui): allow position plots to only show min/max bounds via uiConfiguration #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankmartin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #782. This PR would allow the position plots to only show the min/max bounds of the data optionally, and not all the unique bounds as is the current behaviour.
The proposed solution here is to allow a new watchable value in the
viewer.uiConfigurationwhich is calledshowAllDimensionPlotBounds. So you could see only the min/max dimension bounds by settingviewer.uiConfiguration.showAllDimensionPlotBounds.value = false. That would look like:In contrast to:
The setting should apply to the global viewer position plots, and also to position plots that are made from new layer groups which don't have their position linked to the global position.
I also considered this being in the settings that the user can change, so it would be in the state. But I think it is more in line with other UI change patterns that this is part of the
uiConfiguration.