Enhancement/10475 siwg block options #11683
Merged
+286
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook is ready:
|
|
Build files for bf37ad6 have been deleted. |
|
Size Change: +769 B (+0.04%) Total Size: 2.18 MB ℹ️ View Unchanged
|
|
JS test is failing for unrelated reason. E2E nightly is failing for all blocks as it requires V3 of json config, but it is outside of scope of this issue. |
zutigrm
commented
Oct 24, 2025
Comment on lines
+112
to
+113
| __next40pxDefaultSize | ||
| __nextHasNoMarginBottom |
There was a problem hiding this comment.
SelectControl and TextControl are getting depricated php notices unless these props are included
There was a problem hiding this comment.
Let's add some documentation for that in the actual component then, preferably with links to the props or the code you found this in, since without any context these look strange/unintuitive.
There was a problem hiding this comment.
I extracted it from the deprication notice that was raised in CI e2e. Added as short inline comment
tofumatt
requested changes
Oct 27, 2025
Comment on lines
64
to
66
| function getSelectValue( value ) { | ||
| return value ?? ''; | ||
| } |
There was a problem hiding this comment.
This is probably more "don't repeat yourself" than is needed; it's fine to inline ?? '' for the three values this applies to 😅
Suggested change
| function getSelectValue( value ) { | |
| return value ?? ''; | |
| } |
Comment on lines
+112
to
+113
| __next40pxDefaultSize | ||
| __nextHasNoMarginBottom |
There was a problem hiding this comment.
Let's add some documentation for that in the actual component then, preferably with links to the props or the code you found this in, since without any context these look strange/unintuitive.
| <TextControl | ||
| label={ __( 'CSS class', 'google-site-kit' ) } | ||
| help={ __( | ||
| 'Add optional classes to customise the button in the editor and on the frontend.', |
There was a problem hiding this comment.
(We supply localisation strings in American English, not International English.)
Suggested change
| 'Add optional classes to customise the button in the editor and on the frontend.', | |
| 'Add optional classes to customize the button in the editor and on the frontend.', |
| __nextHasNoMarginBottom | ||
| /> | ||
| <TextControl | ||
| label={ __( 'CSS class', 'google-site-kit' ) } |
There was a problem hiding this comment.
"HTML class" kinda seems more appropriate, but I'm fine with either 😅
tofumatt
reviewed
Oct 28, 2025
| options={ createSelectOptions( | ||
| SIGN_IN_WITH_GOOGLE_SHAPES | ||
| ) } | ||
| // Opt in to new WP components styles (6.7–7.1): |
There was a problem hiding this comment.
Suggested change
| // Opt in to new WP components styles (6.7–7.1): | |
| // Opt-in to new WordPress components styles (6.7–7.1): |
Also—what do the version numbers mean? Are they the only versions of WordPress that are being opted-in to the new styles? What about pre-6.7 users? We do support older versions of WordPress than 6.7.
There was a problem hiding this comment.
I updated the comment to mention this is needed for v6.7+ but it doesn't affect pre 6-7, as it will be ignored
tofumatt
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist