-
Notifications
You must be signed in to change notification settings - Fork 328
Enhancement/#11541 - Decouple Google Tag Gateway health status from GTG settings #11881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hussain-t
wants to merge
38
commits into
develop
Choose a base branch
from
enhancement/#11541-decouple-gtg-heath-status
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and update related methods.
…ved health monitoring. Update methods to utilize health state data and enhance health check functionality.
…e management. Add new endpoints for gtg-health and gtg-health-checks. Update existing methods to return combined health data for backward compatibility.
…am and Mpath health status. Update related methods for consistency across ads, analytics-4, and tagmanager modules.
… status checks. Replace previous health checks with upstream and Mpath health checks.
…Google_Tag_Gateway_Controller.
…ust state management. Replace deprecated server requirement checks with upstream and Mpath health checks.
… and adjust test cases for upstream and Mpath health statuses.
…ed settings and incorporate new GTG health checks for upstream and Mpath statuses.
…t checks with new health checks for upstream and Mpath statuses across ads and analytics-4 modules.
…ream and Mpath statuses.
…nt new GTG health checks for upstream and Mpath statuses, removing deprecated settings.
… health check status wording.
…ecks and settings.
…for improved health checks.
…ons and remove deprecated properties.
…ag_Gateway_Health and update health check assertions.
…Gateway settings and health data.
|
Storybook is ready:
|
|
Build files for 31cfbfa are ready:
|
|
Size Change: +79 B (0%) Total Size: 2.19 MB ℹ️ View Unchanged
|
…or deprecation handling in is_google_tag_gateway_active test.
…g deprecated options to prevent issues during updates.
…health fields for pre-migration state simulation.
…s on isUpstreamHealthy and isMpathHealthy fields.
…ions. Initialize health data with default null values before migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist