Skip to content

Move rollout related configs from cluster config to rollout_config. #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

Move rollout related configs from cluster config to rollout_config. #630

merged 1 commit into from
Oct 28, 2025
+79 −80

Conversation

@wang2yn84
Copy link
Collaborator

@wang2yn84 wang2yn84 commented Oct 27, 2025 •
edited
Loading

Current rollout configs are in both rl_cluster and rollout_config. This PR converge to one place.

Reference

Colab Notebook

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and all unit tests pass.
  • I have added all appropriate doc-strings/documentation.
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have signed the Contributor License Agreement.
  • I have followed Contribution Guidelines.

@copybara-service copybara-service bot merged commit 763fcd5 into main Oct 28, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianshub tianshub Awaiting requested review from tianshub tianshub is a code owner

@lc5211 lc5211 Awaiting requested review from lc5211 lc5211 is a code owner

@hgao327 hgao327 Awaiting requested review from hgao327 hgao327 is a code owner

@sizhit2 sizhit2 Awaiting requested review from sizhit2 sizhit2 is a code owner

@abheesht17 abheesht17 Awaiting requested review from abheesht17 abheesht17 is a code owner

@jiangyangmu jiangyangmu Awaiting requested review from jiangyangmu jiangyangmu is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wang2yn84