-
Notifications
You must be signed in to change notification settings - Fork 134
[ci] Roll pinned nightly toolchain #2736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Roll pinned nightly toolchain #2736
Conversation
Summary of ChangesHello @google-pr-creation-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the continuous integration configuration to utilize a more recent nightly Rust toolchain. This ensures that automated builds and tests are executed against the latest specified nightly compiler, maintaining compatibility and leveraging recent language features or fixes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the pinned nightly toolchain version. However, the date used for the toolchain (nightly-2025-10-17) appears to contain an incorrect year. Since toolchains for future dates are not available, this will likely cause the CI builds to fail. This should be corrected, and the automation that created this PR should be investigated to fix the root cause of the incorrect year.
| # The versions of the stable and nightly compiler toolchains to use in CI. | ||
| pinned-stable = "1.90.0" | ||
| pinned-nightly = "nightly-2025-10-16" | ||
| pinned-nightly = "nightly-2025-10-17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The year 2025 in the nightly toolchain version is incorrect because toolchains for future dates are not available. This will cause CI to fail when it attempts to install this toolchain. The year should be corrected to the current year. The automation that generated this PR may also need to be fixed to prevent this from recurring.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2736 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 20 20
Lines 5423 5423
=======================================
Hits 4821 4821
Misses 602 602 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Automated changes by create-pull-request GitHub action