maxOutstandingMessages per stream#1996
Open
dermasmid wants to merge 2 commits intogoogleapis:mainfrom
Open
Conversation
product-auto-label
bot
added
size: xs
Collaborator
|
Yes. Unfortunately this is being held up by some discussions about what to do with legacy flow control compatibility. |
Member
|
To add slightly more color, dividing the flow control among the total amount of stream does not mean that the messages will be delivered evenly to each streaming pull stream. The total throughput could be limited in that case. |
Collaborator
|
But importantly for this PR, that change could cause unexpected side effects, which is why we haven't done it yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
maxOutstandingMessagesis set per stream so we should divide by num of streams, right?