GDPR Chart Zoom (part 2) #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
laptou
commented
Jul 31, 2020
laptou
commented
- Modify styles to accommodate zooming
- Connect zoom to mouse wheel event
Merged
gracetian6
approved these changes
Jul 31, 2020
jessicaslaughter
approved these changes
Aug 6, 2020
| const {min, max, pow} = Math; | ||
| const scale = pow(10, ev.deltaY / 100); | ||
|
|
||
| const finalZoom = min(max(this.zoom * scale, 0.1), 3); |
Collaborator
There was a problem hiding this comment.
You should add a brief comment explaining why this calculation is necessary
Contributor
There was a problem hiding this comment.
+1, you've got several magic numbers and exponents that could use explaining.
jpnickolas
approved these changes
Aug 7, 2020
| const {min, max, pow} = Math; | ||
| const scale = pow(10, ev.deltaY / 100); | ||
|
|
||
| const finalZoom = min(max(this.zoom * scale, 0.1), 3); |
Contributor
There was a problem hiding this comment.
+1, you've got several magic numbers and exponents that could use explaining.
| const finalZoom = min(max(this.zoom * scale, 0.1), 3); | ||
| const finalScale = finalZoom / this.zoom; | ||
|
|
||
| // point under user's cursor should not move on scroll |
Contributor
There was a problem hiding this comment.
Good declarative comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.