-
Notifications
You must be signed in to change notification settings - Fork 103
Add immediate size validation tests for pipeline layout creation. #4572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add immediate size validation tests for pipeline layout creation. #4572
Conversation
41cde25 to
3a32182
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds validation tests for the experimental immediateSize attribute used in pipeline layout creation. The tests verify that immediateSize must be a multiple of 4 and must not exceed device.limits.maxImmediateSize.
Changes:
- Added a new test
immediate_data_sizeto validateimmediateSizeparameter constraints - Added
supportsImmediateDatahelper function to check for immediate data support
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/webgpu/api/validation/createPipelineLayout.spec.ts | Added validation test for immediateSize parameter with edge case coverage including valid/invalid multiples of 4 and boundary values |
| src/common/util/util.ts | Added supportsImmediateData helper function to detect immediate data feature support through prototype and language feature checks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3a32182 to
49d9432
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
42d8647 to
33dc628
Compare
immediateSize attribute is used for pipeline layout creation. It requires immediateSize must be a multiple of 4 and immediateSize must be smaller or equal to maxImmediateSize.
33dc628 to
fe6a4f3
Compare
|
This test case caught a validation issue in Dawn which doesn't check alignment during pipeline layout creation. |
immediateSize attribute is used for pipeline layout creation. It requires immediateSize must be a multiple of 4 and immediateSize must be smaller or equal to maxImmediateSize.
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.