-
Notifications
You must be signed in to change notification settings - Fork 102
Add immediate size validation cases for pipeline creation #4573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add immediate size validation cases for pipeline creation #4573
Conversation
|
Results for build job (at 264b3a4): +webgpu:api,validation,compute_pipeline:pipeline_creation_immediate_size_mismatch:* - 12 cases, 12 subcases (~1/case)
-webgpu:api,validation,render_pipeline,misc:external_texture:* - 1 cases, 1 subcases (~1/case)
+webgpu:api,validation,render_pipeline,misc:external_texture:* - 2 cases, 2 subcases (~1/case)
+webgpu:api,validation,render_pipeline,misc:pipeline_creation_immediate_size_mismatch:* - 18 cases, 18 subcases (~1/case)
-TOTAL: 285993 cases, 2344970 subcases
+TOTAL: 286024 cases, 2345001 subcases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds validation test cases for immediate data size checks during pipeline creation. The tests verify that pipeline creation fails when shaders use immediate data larger than the immediateSize specified in the pipeline layout or larger than maxImmediateSize when using automatic layout.
Changes:
- Added helper function
supportsImmediateDatato check browser support for immediate data - Added
pipeline_creation_immediate_size_mismatchtest for compute pipelines - Added
pipeline_creation_immediate_size_mismatchtest for render pipelines
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/common/util/util.ts | Added supportsImmediateData helper function to detect immediate data feature support |
| src/webgpu/api/validation/compute_pipeline.spec.ts | Added test to validate immediate size checks during compute pipeline creation |
| src/webgpu/api/validation/render_pipeline/misc.spec.ts | Added test to validate immediate size checks during render pipeline creation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cf15532 to
2127eae
Compare
ab59c0d to
7edddc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add cases to validate immediate size checks during both compute and render pipeline creation.
7edddc0 to
438463e
Compare
|
@shaoboyan091 sorry I've been slow at picking up these re-reviews. To make it a bit easier could you please "resolve" any copilot review comments before sending for review? (either by addressing them or by ignoring them) Having them open makes it harder to review the PR, but I've also noticed that it generates some useful suggestions so I don't want to necessarily ignore them either. |
|
@kainino0x Sure, will do. Thanks! |
Add cases to validate immediate size checks during both compute and render pipeline creation.
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.